Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP keywords should not be used as function/parameter names #449

Merged
merged 1 commit into from
May 24, 2024

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented May 24, 2024

Change logs

CPP keywords should not be used as function/parameter names. Also extern "C" will not work in this case.

current change remove the delete which defined as parameter.

Why are the changes needed?

nope

Does this PR introduce any user-facing change?

nope

How was this patch tested?

nope

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@my-ship-it my-ship-it merged commit c226e0c into apache:main May 24, 2024
10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
Also extern "C" will not work in this case. Current change remove the delete which defined as parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants